Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from addys positions -> summary endpoint for total wallet balance #6358

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Migrate from addys positions -> summary endpoint for total wallet balance #6358

merged 1 commit into from
Dec 20, 2024

Conversation

maxbbb
Copy link
Contributor

@maxbbb maxbbb commented Dec 19, 2024

Fixes APP-1808

What changed (plus any additional context for devs)

  • Change total balance calculation to use positions value returned from summary endpoint rather than fetching each accounts positions individually and calculating the total from that.

What to test

  • That your total account balance is correct

@linear Linear
Copy link

linear bot commented Dec 19, 2024

APP-1808 Migrate from addys positions -> summary endpoint for total wallet balance

@maxbbb maxbbb requested review from benisgold and derHowie December 19, 2024 22:59
@brunobar79
Copy link
Member

Launch in simulator or device for 8be52c8

@brunobar79 brunobar79 added the release for release blockers and release candidate branches label Dec 20, 2024
derHowie
derHowie approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@brunobar79 brunobar79 merged commit 3e7d5b1 into develop Dec 20, 2024
7 of 8 checks passed
@brunobar79 brunobar79 deleted the @kane/positions-balance branch December 20, 2024 16:47
@BrodyHughes BrodyHughes mentioned this pull request Dec 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derHowie derHowie derHowie approved these changes

@walmat walmat walmat approved these changes

@benisgold benisgold Awaiting requested review from benisgold

Assignees
No one assigned
Labels
release for release blockers and release candidate branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxbbb @brunobar79 @walmat @derHowie