Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network colors in NetworkSelector #6361

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

walmat
Copy link
Contributor

@walmat walmat commented Dec 20, 2024

Fixes APP-2199

What changed (plus any additional context for devs)

We were using an old util that requires us to add entries to foregroundColors that is no longer supported. Changed it to pull directly from the theme instead.

@christianbaroni noticed that our Arbitrum color doesn't correspond to what's in the Figma. Didn't want to change the hex without consulting you first.

Here's the FIgma:
Screenshot 2024-12-20 at 10 17 17 AM

Here's our current hex: #2D374B
Screenshot 2024-12-20 at 10 18 34 AM

Screen recordings / screenshots

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-20.at.10.14.14.mp4
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-20.at.10.13.20.mp4

What to test

Copy link

linear bot commented Dec 20, 2024

@walmat walmat added the release for release blockers and release candidate branches label Dec 20, 2024
Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-12-20 at 10 32 09 AM Screenshot 2024-12-20 at 10 32 04 AM Screenshot 2024-12-20 at 10 31 58 AM

@brunobar79 brunobar79 merged commit 4a4bbe8 into develop Dec 20, 2024
7 of 8 checks passed
@brunobar79 brunobar79 deleted the @matthew/APP-2199 branch December 20, 2024 16:24
@brunobar79
Copy link
Member

Launch in simulator or device for 26e439c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release for release blockers and release candidate branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants