Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add imported check on backup prompt #6377

Merged
merged 2 commits into from
Jan 3, 2025
Merged

add imported check on backup prompt #6377

merged 2 commits into from
Jan 3, 2025

Conversation

walmat
Copy link
Contributor

@walmat walmat commented Jan 3, 2025

Fixes APP-2240

What changed (plus any additional context for devs)

Prevents the backup prompt from firing for imported wallets

Screen recordings / screenshots

What to test

backup prompt annoyances

Copy link

linear bot commented Jan 3, 2025

APP-2240 Backups hotfix

@walmat walmat requested review from brunobar79 and derHowie January 3, 2025 16:11
@walmat walmat added the release for release blockers and release candidate branches label Jan 3, 2025
@brunobar79
Copy link
Member

Launch in simulator or device for 6a70182

Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on both iCloud and drive ✅

@brunobar79
Copy link
Member

Launch in simulator or device for a84f96b

Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@walmat walmat merged commit 5722852 into develop Jan 3, 2025
8 checks passed
@walmat walmat deleted the @matthew/APP-2240 branch January 3, 2025 21:29
ibrahimtaveras00 pushed a commit that referenced this pull request Jan 4, 2025
* add imported check on backup prompt

* add navigation to backup prompt on new group creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release for release blockers and release candidate branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants