Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nft icon sheet present & prioritize backup sheet #6379

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

maxbbb
Copy link
Contributor

@maxbbb maxbbb commented Jan 3, 2025

Fixes APP-2241

What changed (plus any additional context for devs)

  • Prioritizes showing backup sheet on app startup over nft icon unlocks
  • Wraps nft icon unlock sheet navigation in triggerOnSwipeLayout, removing previous setTimeout hack.

Copy link

linear bot commented Jan 3, 2025

@brunobar79 brunobar79 requested review from walmat, brunobar79 and benisgold and removed request for benisgold January 3, 2025 20:30
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brunobar79 brunobar79 requested a review from derHowie January 3, 2025 20:36
@brunobar79 brunobar79 added the release for release blockers and release candidate branches label Jan 3, 2025
@brunobar79
Copy link
Member

Launch in simulator or device for a33e939

@maxbbb maxbbb merged commit 3bb8e9a into develop Jan 3, 2025
8 checks passed
@maxbbb maxbbb deleted the @kane/fix-nft-unlock-sheet branch January 3, 2025 23:01
ibrahimtaveras00 pushed a commit that referenced this pull request Jan 4, 2025
* give priority to backup sheet over nft icon unlocks, wrap nft icon unlocks in swipe layout handler

* revert wallet backup sheet priority
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release for release blockers and release candidate branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants