Implement new logic for backup prompt #6388
Conversation
| const { backupProvider, timesPromptedForBackup, lastBackupPromptAt } = backupsStore.getState(); | ||
|
|
||
| // prompt for backup every week if first time prompting, otherwise prompt every 2 weeks | ||
| if (lastBackupPromptAt && Date.now() - lastBackupPromptAt < oneWeekInMs * (timesPromptedForBackup + 1)) { |
There was a problem hiding this comment.
Initially I thought this behavior would delay the next prompt by an additional week after every prompt (2 weeks, 3 weeks, etc). But it seems that timesPromptedForBackup is only ever set to 0 or 1, which is kind of confusing because I would assume timesPromptedForBackup gets incremented every time they are prompted.
There was a problem hiding this comment.
According to spec we want 1 week after first prompt then every 2 weeks until backed up
There was a problem hiding this comment.
Yeah I get that was just saying the variable being named timesPromptedForBackup was confusing because it does not actually represent the number of times a user has been prompted for backup, it's only ever 0 or 1. Just a variable naming complaint, doesn't actually matter
There was a problem hiding this comment.
Ah yeah, I could name it something like weeklyMultiplier or something more representative
Fixes APP-2237
What changed (plus any additional context for devs)
1. Backup Sheet Component Updates
New Components
CloudBackupPromptcomponent for cloud backup flowsManualBackupPromptcomponent for manual backup flowsBackup Step Types Refactor
backup_prompt_manualbackup_prompt_cloudcreate_cloud_backup2. Backup Store Enhancements
New State Management
timesPromptedForBackupcounterlastBackupPromptAttimestamp trackingPrompt Logic
3. Wallet Import Flow Improvements
Cloud Backup Integration
Error Handling
This PR significantly improves the backup system by introducing separate prompts for different backup types, implementing a smarter prompting system, and adding proper state management for backup-related user interactions.
Screen recordings / screenshots
// wip
What to test
TF 1.9.53 (7)