Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix address copy crash (and floating emojis animation) #6392

Merged
merged 9 commits into from
Jan 10, 2025

Conversation

brunobar79
Copy link
Member

@brunobar79 brunobar79 commented Jan 10, 2025

Fixes APP-2232

What changed (plus any additional context for devs)

  • Converted all floating emoji's related files to TS
  • Fix type issues
  • Fix the floating emoji's animation, which has been broken for a while

Screen recordings / screenshots

Screen.Recording.2025-01-09.at.8.15.13.PM.mov

What to test

Tap copy on the wallet screen. Shouldn't crash and the animation should work again

@brunobar79 brunobar79 added the release for release blockers and release candidate branches label Jan 10, 2025
@brunobar79
Copy link
Member Author

Launch in simulator or device for a300a86

@brunobar79
Copy link
Member Author

Launch in simulator or device for 62db8fa

@brunobar79
Copy link
Member Author

Launch in simulator or device for eba2ee8

@walmat walmat merged commit 91af6c1 into develop Jan 10, 2025
8 checks passed
@walmat walmat deleted the @bruno/fix-floating-emojis-crash-android branch January 10, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready release for release blockers and release candidate branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants