Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust default queryClient cacheTime #6403

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

christianbaroni
Copy link
Member

@christianbaroni christianbaroni commented Jan 15, 2025

What changed (plus any additional context for devs)

  • Turns out cacheTime is the time after which inactive query data is garbage collected, not the time that data is stored for
  • This sets the default cacheTime back to 5 minutes, which is RQ's default

Screen recordings / screenshots

What to test

@christianbaroni christianbaroni added release for release blockers and release candidate branches performance performance related improvements labels Jan 15, 2025
Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@brunobar79
Copy link
Member

Launch in simulator or device for 24d5737

@christianbaroni christianbaroni merged commit d800895 into develop Jan 16, 2025
8 checks passed
@christianbaroni christianbaroni deleted the @christian/cache-time-fix branch January 16, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance performance related improvements release for release blockers and release candidate branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants