bump slippage from 2 to 5 (except mainnet, polygon and bsc) #6419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derHowie
approved these changes
Jan 23, 2025
walmat
approved these changes
Jan 23, 2025
src/model/remoteConfig.ts
Outdated
There was a problem hiding this comment.
possible to dynamically construct this? I just wrote this on the BX: https://github.com/rainbow-me/browser-extension/blob/9ab5b8bbe61a73f841af3ccb9872f1dd34d74fe1/src/core/firebase/remoteConfig.ts#L36-L42
There was a problem hiding this comment.
The moment we have more variations this gets really nasty so I'm not gonna do it.
| @@ -46,6 +46,8 @@ import { IS_APK_BUILD } from 'react-native-dotenv'; | |||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |||
| import isTestFlight from '@/helpers/isTestFlight'; | |||
|
|
|||
| const DEFAULT_SLIPPAGE_BIPS = 500; | |||
There was a problem hiding this comment.
I think we should share this constant with the remoteConfig so that changing one changes both?
There was a problem hiding this comment.
I agree but this needs more work so whenever I have time I'm gonna do this:
https://linear.app/rainbow/issue/APP-2286/clean-up-slippage-defaults
…efault-slippage-bips
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-2263
What changed (plus any additional context for devs)
Bump slippage from 2 to 5 (except mainnet, polygon and bsc)
Screen recordings / screenshots
What to test
Swap review sheet default slippage for the specified chains