Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overridable univ3 fees/ticks literals for univ3 based dexes #18

Merged
merged 10 commits into from
Jun 29, 2024

Conversation

rouzwelt
Copy link
Collaborator

@rouzwelt rouzwelt commented Jun 26, 2024

Motivation

Solution

  • make uniswapv3 base class's fees and ticks overridable for child classes (dex classes)
  • update DataFetcher tests to include checks for valid rp4 routes to ensures validity of dex literals
  • add tests for reading fee/tick map from univ3 based dex factories and check against the literals in dexes

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs

@rouzwelt rouzwelt added the enhancement New feature or request label Jun 26, 2024
@rouzwelt rouzwelt requested a review from hardyjosh June 26, 2024 04:23
@rouzwelt rouzwelt self-assigned this Jun 26, 2024
@rouzwelt rouzwelt changed the title overridable univ3 fees/ticks literals for dexes overridable univ3 fees/ticks literals for univ3 based dexes Jun 26, 2024
Copy link

@hardyjosh hardyjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see tests for the changes that were made.

@rouzwelt
Copy link
Collaborator Author

I can't see tests for the changes that were made.

there was a missing commit, it is pushed now, but tests for dexes are in data fetcher where the loop test exists, running the datafetchere on each chain and dex and checking the results

@rouzwelt rouzwelt requested a review from hardyjosh June 26, 2024 15:27
@hardyjosh hardyjosh merged commit a9de0f7 into rain-fork Jun 29, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants