Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support Velodrome v2 #33

Closed
wants to merge 5 commits into from
Closed

add support Velodrome v2 #33

wants to merge 5 commits into from

Conversation

rouzwelt
Copy link
Collaborator

@rouzwelt rouzwelt commented Jan 29, 2025 •
edited
Loading

Motivation

  • add support for Velodrom V2 protocol, which is a custom fork of UniV2
  • add AerodromeV2 dex which is VelodromeV2 protocol type dex
  • add VelodromeV2 dex which is VelodromeV2 protocol type dex

Solution

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@rouzwelt rouzwelt added the new dex Added a new dex support label Jan 29, 2025
@rouzwelt rouzwelt self-assigned this Jan 29, 2025
@rouzwelt rouzwelt marked this pull request as ready for review January 29, 2025 23:46
@rouzwelt rouzwelt requested a review from hardyjosh January 29, 2025 23:47
@rouzwelt
Copy link
Collaborator Author

rouzwelt commented Feb 1, 2025

cannot be supported, not compatible at RP4 contract level due to custom swap fees calcs resulting in invalid k()

@rouzwelt rouzwelt closed this Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardyjosh hardyjosh Awaiting requested review from hardyjosh

Assignees

@rouzwelt rouzwelt

Labels
new dex Added a new dex support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rouzwelt