Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

280 update validation for sdk #281

Merged
merged 7 commits into from
Nov 15, 2024
Merged

280 update validation for sdk #281

merged 7 commits into from
Nov 15, 2024

Conversation

jmsm412
Copy link
Collaborator

@jmsm412 jmsm412 commented Nov 14, 2024

Affected endpoints (for testing):

  • files/update/:id - PATCH - Renamed parameter from mediaId to id
  • files/remove/:id - DELETE - Renamed parameter from mediaId to id
  • files/:id/unlocks - GET - Added validation that id is defined
  • files/:id/unlocks - POST - Added validation that id is defined, added validator for the offers body param
  • files/:id/unlocks - DELETE - Added validation that id is defined, addede validator for the offer body param

@jmsm412 jmsm412 added the backend (new) relates to backend APIs label Nov 14, 2024
@jmsm412 jmsm412 self-assigned this Nov 14, 2024
@jmsm412 jmsm412 linked an issue Nov 14, 2024 that may be closed by this pull request
Update validation for SDK #280
Closed
@jmsm412 jmsm412 changed the base branch from main to dev November 14, 2024 19:41
@jmsm412
Copy link
Collaborator Author

jmsm412 commented Nov 14, 2024

Closes #280

sarora180673
sarora180673 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@sarora180673 sarora180673 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified

@sarora180673 sarora180673 merged commit 098558d into dev Nov 15, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarora180673 sarora180673 sarora180673 approved these changes

@SeanM322 SeanM322 Awaiting requested review from SeanM322

Assignees

@jmsm412 jmsm412

Labels
backend (new) relates to backend APIs
Projects
@rairprotocol's rair-dapp
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update validation for SDK
2 participants
@jmsm412 @sarora180673