-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : handle dividends when handling XIRR #349
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe recent updates involve refining the transaction filtering mechanism in a Java repository by ensuring only transactions with a non-null balance are considered. Additionally, a service method now includes a note about the importance of accounting for dividends when calculating the balance for specific fund types. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
src/main/java/com/learning/mfscreener/service/UserTransactionDetailsService.java (1)
25-26
: Clarify the comment regarding dividend handling.The comment could be more specific about how dividends are added to the final balance. Consider rephrasing for clarity and detail, such as specifying the method or logic used to include dividends.
Summary by CodeRabbit