feat : Remove implicit web annotation names

rajadilipkolli · Nov 16, 2023 · bb18e9b · bb18e9b
1 parent 993f45c
commit bb18e9b
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 74 deletions.
diff --git a/...g-service/src/main/java/com/example/catalogservice/web/controllers/ProductController.java b/...g-service/src/main/java/com/example/catalogservice/web/controllers/ProductController.java
@@ -41,25 +41,13 @@ public ProductController(ProductService productService) {
 
     @GetMapping
     public Mono<PagedResult<ProductResponse>> getAllPosts(
-            @RequestParam(
-                            value = "pageNo",
-                            defaultValue = AppConstants.DEFAULT_PAGE_NUMBER,
-                            required = false)
+            @RequestParam(defaultValue = AppConstants.DEFAULT_PAGE_NUMBER, required = false)
                     int pageNo,
-            @RequestParam(
-                            value = "pageSize",
-                            defaultValue = AppConstants.DEFAULT_PAGE_SIZE,
-                            required = false)
+            @RequestParam(defaultValue = AppConstants.DEFAULT_PAGE_SIZE, required = false)
                     int pageSize,
-            @RequestParam(
-                            value = "sortBy",
-                            defaultValue = AppConstants.DEFAULT_SORT_BY,
-                            required = false)
+            @RequestParam(defaultValue = AppConstants.DEFAULT_SORT_BY, required = false)
                     String sortBy,
-            @RequestParam(
-                            value = "sortDir",
-                            defaultValue = AppConstants.DEFAULT_SORT_DIRECTION,
-                            required = false)
+            @RequestParam(defaultValue = AppConstants.DEFAULT_SORT_DIRECTION, required = false)
                     String sortDir) {
         return productService.findAllProducts(pageNo, pageSize, sortBy, sortDir);
     }
@@ -81,7 +69,7 @@ public Mono<ResponseEntity<ProductResponse>> getProductByProductCode(
 
     @GetMapping("/exists")
     public Mono<ResponseEntity<Boolean>> productExistsByProductCodes(
-            @RequestParam(name = "productCodes") List<String> productCodes) {
+            @RequestParam List<String> productCodes) {
         return productService.productExistsByProductCodes(productCodes).map(ResponseEntity::ok);
     }
 

diff --git a/...rvice/src/main/java/com/example/inventoryservice/web/controllers/InventoryController.java b/...rvice/src/main/java/com/example/inventoryservice/web/controllers/InventoryController.java
@@ -36,25 +36,13 @@ public class InventoryController {
 
     @GetMapping
     public PagedResult<Inventory> getAllInventories(
-            @RequestParam(
-                            value = "pageNo",
-                            defaultValue = AppConstants.DEFAULT_PAGE_NUMBER,
-                            required = false)
+            @RequestParam(defaultValue = AppConstants.DEFAULT_PAGE_NUMBER, required = false)
                     int pageNo,
-            @RequestParam(
-                            value = "pageSize",
-                            defaultValue = AppConstants.DEFAULT_PAGE_SIZE,
-                            required = false)
+            @RequestParam(defaultValue = AppConstants.DEFAULT_PAGE_SIZE, required = false)
                     int pageSize,
-            @RequestParam(
-                            value = "sortBy",
-                            defaultValue = AppConstants.DEFAULT_SORT_BY,
-                            required = false)
+            @RequestParam(defaultValue = AppConstants.DEFAULT_SORT_BY, required = false)
                     String sortBy,
-            @RequestParam(
-                            value = "sortDir",
-                            defaultValue = AppConstants.DEFAULT_SORT_DIRECTION,
-                            required = false)
+            @RequestParam(defaultValue = AppConstants.DEFAULT_SORT_DIRECTION, required = false)
                     String sortDir) {
         return inventoryService.findAllInventories(pageNo, pageSize, sortBy, sortDir);
     }

diff --git a/order-service/src/main/java/com/example/orderservice/services/CatalogServiceProxy.java b/order-service/src/main/java/com/example/orderservice/services/CatalogServiceProxy.java
@@ -16,5 +16,5 @@ Licensed under MIT License Copyright (c) 2022-2023 Raja Kolli.
 public interface CatalogServiceProxy {
 
     @GetExchange("/api/catalog/exists")
-    boolean productsExistsByCodes(@RequestParam(name = "productCodes") List<String> productCodes);
+    boolean productsExistsByCodes(@RequestParam List<String> productCodes);
 }
diff --git a/order-service/src/main/java/com/example/orderservice/web/controllers/OrderController.java b/order-service/src/main/java/com/example/orderservice/web/controllers/OrderController.java
@@ -47,25 +47,13 @@ public class OrderController implements OrderApi {
 
     @GetMapping
     public PagedResult<OrderResponse> getAllOrders(
-            @RequestParam(
-                            value = "pageNo",
-                            defaultValue = AppConstants.DEFAULT_PAGE_NUMBER,
-                            required = false)
+            @RequestParam(defaultValue = AppConstants.DEFAULT_PAGE_NUMBER, required = false)
                     int pageNo,
-            @RequestParam(
-                            value = "pageSize",
-                            defaultValue = AppConstants.DEFAULT_PAGE_SIZE,
-                            required = false)
+            @RequestParam(defaultValue = AppConstants.DEFAULT_PAGE_SIZE, required = false)
                     int pageSize,
-            @RequestParam(
-                            value = "sortBy",
-                            defaultValue = AppConstants.DEFAULT_SORT_BY,
-                            required = false)
+            @RequestParam(defaultValue = AppConstants.DEFAULT_SORT_BY, required = false)
                     String sortBy,
-            @RequestParam(
-                            value = "sortDir",
-                            defaultValue = AppConstants.DEFAULT_SORT_DIRECTION,
-                            required = false)
+            @RequestParam(defaultValue = AppConstants.DEFAULT_SORT_DIRECTION, required = false)
                     String sortDir) {
         return orderService.findAllOrders(pageNo, pageSize, sortBy, sortDir);
     }
@@ -126,15 +114,9 @@ public boolean create() {
     @GetMapping("/all")
     @Override
     public List<OrderDto> all(
-            @RequestParam(
-                            value = "pageNo",
-                            defaultValue = AppConstants.DEFAULT_PAGE_NUMBER,
-                            required = false)
+            @RequestParam(defaultValue = AppConstants.DEFAULT_PAGE_NUMBER, required = false)
                     int pageNo,
-            @RequestParam(
-                            value = "pageSize",
-                            defaultValue = AppConstants.DEFAULT_PAGE_SIZE,
-                            required = false)
+            @RequestParam(defaultValue = AppConstants.DEFAULT_PAGE_SIZE, required = false)
                     int pageSize) {
         return orderKafkaStreamService.getAllOrders(pageNo, pageSize);
     }

diff --git a/...-service/src/main/java/com/example/paymentservice/web/controllers/CustomerController.java b/...-service/src/main/java/com/example/paymentservice/web/controllers/CustomerController.java
@@ -34,25 +34,13 @@ public class CustomerController {
 
     @GetMapping
     public PagedResult<CustomerResponse> getAllCustomers(
-            @RequestParam(
-                            value = "pageNo",
-                            defaultValue = AppConstants.DEFAULT_PAGE_NUMBER,
-                            required = false)
+            @RequestParam(defaultValue = AppConstants.DEFAULT_PAGE_NUMBER, required = false)
                     int pageNo,
-            @RequestParam(
-                            value = "pageSize",
-                            defaultValue = AppConstants.DEFAULT_PAGE_SIZE,
-                            required = false)
+            @RequestParam(defaultValue = AppConstants.DEFAULT_PAGE_SIZE, required = false)
                     int pageSize,
-            @RequestParam(
-                            value = "sortBy",
-                            defaultValue = AppConstants.DEFAULT_SORT_BY,
-                            required = false)
+            @RequestParam(defaultValue = AppConstants.DEFAULT_SORT_BY, required = false)
                     String sortBy,
-            @RequestParam(
-                            value = "sortDir",
-                            defaultValue = AppConstants.DEFAULT_SORT_DIRECTION,
-                            required = false)
+            @RequestParam(defaultValue = AppConstants.DEFAULT_SORT_DIRECTION, required = false)
                     String sortDir) {
         FindCustomersQuery findCustomersQuery =
                 new FindCustomersQuery(pageNo, pageSize, sortBy, sortDir);