-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : reduce access modifier where possible #799
Conversation
WalkthroughThe changes involve making several classes and methods package-private by removing the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- inventory-service/src/main/java/com/example/inventoryservice/InventoryServiceApplication.java (1 hunks)
- inventory-service/src/main/java/com/example/inventoryservice/config/Initializer.java (1 hunks)
- inventory-service/src/main/java/com/example/inventoryservice/config/KafkaListenerConfig.java (1 hunks)
- inventory-service/src/main/java/com/example/inventoryservice/config/RestTemplateConfig.java (1 hunks)
- inventory-service/src/main/java/com/example/inventoryservice/config/SwaggerConfig.java (1 hunks)
- inventory-service/src/main/java/com/example/inventoryservice/config/WebMvcConfig.java (1 hunks)
- inventory-service/src/main/java/com/example/inventoryservice/config/logging/LoggingAspect.java (1 hunks)
- inventory-service/src/main/java/com/example/inventoryservice/web/controllers/InventoryController.java (3 hunks)
Files skipped from review due to trivial changes (6)
- inventory-service/src/main/java/com/example/inventoryservice/InventoryServiceApplication.java
- inventory-service/src/main/java/com/example/inventoryservice/config/Initializer.java
- inventory-service/src/main/java/com/example/inventoryservice/config/KafkaListenerConfig.java
- inventory-service/src/main/java/com/example/inventoryservice/config/RestTemplateConfig.java
- inventory-service/src/main/java/com/example/inventoryservice/config/SwaggerConfig.java
- inventory-service/src/main/java/com/example/inventoryservice/config/logging/LoggingAspect.java
Additional comments not posted (10)
inventory-service/src/main/java/com/example/inventoryservice/config/WebMvcConfig.java (2)
25-25
: Good practice: Added @nonnull annotation.The addition of the
@NonNull
annotation to theregistry
parameter is a good practice to ensure that it is not null, enhancing the robustness of the code.
16-16
: Improved encapsulation: Class access modifier changed to package-private.The change of the
WebMvcConfig
class's access modifier frompublic
to package-private enhances encapsulation and potentially improves maintainability and security.inventory-service/src/main/java/com/example/inventoryservice/web/controllers/InventoryController.java (8)
42-42
: Improved encapsulation: Method access modifier changed to package-private.The change of the
getAllInventories
method's access modifier frompublic
to package-private enhances encapsulation.
59-59
: Improved encapsulation: Method access modifier changed to package-private.The change of the
getInventoryByProductCode
method's access modifier frompublic
to package-private enhances encapsulation.
67-67
: Improved encapsulation: Method access modifier changed to package-private.The change of the
getInventoryByProductCodes
method's access modifier frompublic
to package-private enhances encapsulation.
72-72
: Improved encapsulation: Method access modifier changed to package-private.The change of the
updateInventoryWithRandomValue
method's access modifier frompublic
to package-private enhances encapsulation.
79-79
: Improved encapsulation: Method access modifier changed to package-private.The change of the
createInventory
method's access modifier frompublic
to package-private enhances encapsulation.
84-84
: Improved encapsulation: Method access modifier changed to package-private.The change of the
updateInventory
method's access modifier frompublic
to package-private enhances encapsulation.
93-93
: Improved encapsulation: Method access modifier changed to package-private.The change of the
deleteInventory
method's access modifier frompublic
to package-private enhances encapsulation.
33-33
: Improved encapsulation: Class access modifier changed to package-private.The change of the
InventoryController
class's access modifier frompublic
to package-private enhances encapsulation and potentially improves maintainability and security.
No description provided.