Fetch weather data from 2 endpoints in parallel (#15)

- [x] closes #14 - [x] Fix header box-sizing to avoid unneccessary scrollbar
rajatkantinandi · Nov 29, 2020 · 32094a2 · 32094a2 · vercel · Nov 29, 2020
1 parent f3f8c3f
commit 32094a2
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "weather-here",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "private": true,
   "dependencies": {
     "react": "^16.8.6",

diff --git a/public/manifest.json b/public/manifest.json
@@ -6,7 +6,7 @@
   "display": "fullscreen",
   "Scope": "/",
   "start_url": "/",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "icons": [
     {
       "src": "images/icons/icon-72x72.png",

diff --git a/src/App.css b/src/App.css
@@ -26,6 +26,7 @@ body {
   top: 0;
   z-index: 2;
   font-family: 'Lora', serif;
+  box-sizing: border-box;
 }
 
 .header h1 {

diff --git a/src/hooks/useFetchTemp.jsx b/src/hooks/useFetchTemp.jsx
@@ -91,8 +91,10 @@ const useFetchTemp = (unit) => {
 };
 
 const getCombinedTemps = async (location, fromLocalStorage) => {
-  let { temp, temp_max, temp_min, locationName, weather } = await fetchTemp(location, fromLocalStorage);
-  let { comingTemps, comingWeather } = await fetchComingTemp(location, fromLocalStorage);
+  let [{ temp, temp_max, temp_min, locationName, weather }, { comingTemps, comingWeather }] = await Promise.all([
+    fetchTemp(location, fromLocalStorage),
+    fetchComingTemp(location, fromLocalStorage),
+  ]);
 
   if (comingTemps) {
     comingTemps[0][0] = Math.max(temp_max, comingTemps[0][0]);