-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accent MatchParen when cursor is not blinking. #14
Open
shofel
wants to merge
26
commits into
rakr:master
Choose a base branch
from
shofel:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem: when for MatchParen fg=syntax_bg, then block-shaped cursor coloured with bg color, that is become invisible. This makes "another" paren more accented than "this" paren. To fix this, I just swap bg and fg for MatchParen, which solves the problem.
shofel
changed the title
accent MatchParen; subtle SignColumn
Accent MatchParen when cursor is not blinking.
Jul 4, 2018
OH GOD I THANK YOU SO MUCH |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe, this change is almost unopinionated, but just makes the things better :)
The Problem
When for MatchParen fg=syntax_bg, then block-shaped cursor becomes colored with bg_color, and
becomes invisible. This makes "another" paren much more accented than "this" paren.
Fix
To fix this, I just swap bg and fg for MatchParen, which as for me, solves the problem.
Demo video
After watching the demo I've realized, the old variant looks better when the cursor is blinking.
For other cursor shapes (horizontal line, vertical line, non-blinking block) new version looks and feels a way better.
Demo file