-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a validate command to CLI to validate commit messages #58
Conversation
I am not sure what to do with the phpstan error in the static analysis stage. FWIW, this breaks on the |
Hello, I'm really interested with this PR, @hussainweb any news ? :) Thanks |
I'm happy to see most relevant checks are passing now. More tests and docs next. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
============================================
+ Coverage 98.71% 98.76% +0.05%
- Complexity 286 296 +10
============================================
Files 37 39 +2
Lines 779 813 +34
============================================
+ Hits 769 803 +34
Misses 10 10
|
Cool. Codecov is happy. I'll work on the docs tomorrow. |
@ramsey, I completed all the tasks and requesting a review now. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks! 🎉
Description
As discussed in #57 (comment), this PR adds a command to validate a commit message
Motivation and context
More details in #57 and #25.
How has this been tested?
So far, I have added a few tests and mainly tested this manually. This PR is WIP and I will add more tests.
Types of changes
PR checklist