Vue3 test #11640
Closed
Vue3 test #11640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commands run: ➤ yarn migrate ➤ git clean -fdx ➤ nvm use 20 ➤ yarn
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
…uex] This only addresses the complaints made by the cli when running. There are still more instances of createLocalVue https://stackoverflow.com/questions/66932839/typeerror-0-testutils-createlocalvue-is-not-a-function
This was noticed in the CLI when running Ctrl + C to exit the server process
…ore than once with DefinePlugin() It appears to be an update in webpack 4 which we can disable with config.optimization.nodeEnv
Uncaught runtime errors:
ERROR
Catch all routes ("*") must now be defined using a param with a custom regexp. See more at https://next.router.vuejs.org/guide/migration/#removed-star-or-catch-all-routes.
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
An error occurred logging in: proxy must report the same value for the non-writable, non-configurable property '"$ctx"' Signed-off-by: Phillip Rak <[email protected]>
There's a new important change in behavior between Vue2 and Vue3 regarding emitting native events in custom components. I was noticing that AsyncButton was emitting two click events, even though it was specifying $event.stopPropagation(); & $event.preventDefault(); before emitting its own click event. It turns out that the only way to "override" a native event is to specify it in the emits option If a native event (e.g., click) is defined in the emits option, the listener will now only listen to component-emitted click events and no longer respond to native click events. https://vuejs.org/guide/components/events.html#declaring-emitted-events Signed-off-by: Phillip Rak <[email protected]>
… when doing the router replacement in our extendApp code
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
…erences fullPath from resolve()
This removes one of our console warnings
We may want to investigate further why we have to access it using ._value. This most likely should've been taken care of inside entry.js
We weren't calling set anymore which meant we weren't using the correct key when setting the values in some places.
We had this `hasTabs` api which implicitly allowed a chart install override component to implicitly define tabs instead of just having the component define them explicitly. This required prop drilling to work and it doesn't appear to work any longer with dynamic components. Since this was only used in two places I removed support for this and simplified the implementation.
I did this so I could change how that button is referenced in tests. I don't think we ever should've used the add-label attribute.
…rty reference the old id
… consistent with our upgraded library
It passes locally but not when running in CI. This may be a race condition so I'm reordering and waiting on certain conditions when checking titles.
It looks like the pages weren't refreshing between tests.
…deleting an admin
…til a modal showed up which prevented us from testing further
- updating selectors for the inputs - adding another inheritAttrs: false
We got rid of reactivity when we remove Vue.set() I've added it back. In this case it's specifically to make the feature flags table reactive when activating and deactivating flags.
…for the correct features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist