Fix Vue3: Popover regressions in header #11771
Conversation
|
Can this also fix the "Set as login page" menu?
|
|
Sure, I'll give it a try @rak-phillip . I've noticed that too. It should all be around the classes for CSS that have changed. I hope I can finish it tomorrow... |
aalves08
force-pushed
the
11684-popover-fix
branch
from
5e37347
to
587fe2d
Compare
There was a problem hiding this comment.
Everything looks largely the same. The only real difference that I could spot is that the new popovers appear to have a box shadow
PR #11771
2.9
| @@ -92,6 +92,7 @@ export default defineComponent({ | |||
| z-index: z-index(hoverOverContent); | |||
| } | |||
|
|
|||
| // I DON'T THINK iT NEEDS FiXING... I think we delete it... CHECK EDIT->PODS->GENERAL TAB-> PULL SECRETS ::TODO-ALEX | |||
There was a problem hiding this comment.
Can we create an issue for this TODO?
There was a problem hiding this comment.
@rak-phillip since you'll be off until Tuesday and also because of the GH situation, I suggest I take care of the tooltips box-shadow problem and the TODO comment by this issue if that's ok with you
There was a problem hiding this comment.
Sure thing. I really just want to make sure that the TODO gets addressed more than anything else. I'm fine if #11763 will cover it.
Summary
Fixes #11684 #11685 #11740 #11742
Occurred changes and/or fixed issues
LocaleSelectorthemingHeaderuser menudropdownstooltips- NOTE: Set login page menu is still broken, although I think the fix will be pretty similar what I've done on the
Headeruser avatar menu (check PR changes there)Technical notes summary
HeaderAreas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
dropdowns.mov
Checklist