Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve typescript warnings for Rancher Components #11978

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Resolve typescript warnings for Rancher Components #11978

merged 3 commits into from
Sep 24, 2024

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Sep 19, 2024 •
edited
Loading

Summary

This resolves typescript warnings for Rancher Components.

Fixes #11977

Occurred changes and/or fixed issues

  • Update pkg/rancher-components/src/shim-vue.d.ts
  • Remove instances of @ts-nocheck
  • Resolve each error flagged by tsc

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rak-phillip
Update Vue shim for Vue3
c29f3ae 
Signed-off-by: Phillip Rak <[email protected]>
@rak-phillip rak-phillip added this to the v2.10.0 milestone Sep 19, 2024
@rak-phillip rak-phillip marked this pull request as draft September 19, 2024 22:16
@rak-phillip rak-phillip force-pushed the bugfix/11977-typescript-rancher-components branch from 44911da to 39928dd Compare September 19, 2024 22:19
cnotv
cnotv previously approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rak-phillip rak-phillip force-pushed the bugfix/11977-typescript-rancher-components branch from 94b1416 to 532c185 Compare September 20, 2024 22:13
@rak-phillip rak-phillip force-pushed the bugfix/11977-typescript-rancher-components branch from 532c185 to 2a6058d Compare September 23, 2024 21:35
@rak-phillip rak-phillip marked this pull request as ready for review September 23, 2024 21:35
@rak-phillip
Copy link
Member Author

@cnotv this is ready for another review - we finally pass CI 🙃

@cnotv
Copy link
Contributor

cnotv commented Sep 24, 2024

@cnotv this is ready for another review - we finally pass CI 🙃

I was taking my time anyway 😅

@rak-phillip rak-phillip merged commit 3e964c5 into rancher:master Sep 24, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnotv cnotv cnotv approved these changes

Assignees

@rak-phillip rak-phillip

Labels
None yet
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.

Update typing for Rancher Components
2 participants
@rak-phillip @cnotv