Don't use pre-minified Vue version

[moio]

Summary

Fixes #12513

This changes the way scripts are minified and source maps are computed. Instead of using a pre-minified Vue version, use the full version and minify it using the existing minifier.

That moves minification after source map creation, restoring expected resource map functionality.

Occurred changes and/or fixed issues

	Original	With this PR
Javascript file size in dist/js	13 MB	13 MB
Source map file size in dist/js	43 MB	45 MB
Build time reported by yarn	110 s	75 s

File size change is modest, and occurs basically only in source maps which are not loaded by most users. Runtime is also shorter in my setup. All tests were run on 2.9.1.

Technical notes summary

Should be completely transparent to non-developer users.

I hope this works.

Areas or cases that should be tested

Regular test of a new Rancher version should be more than sufficient to catch any regressions, which by the way are not expected as the change uses a value that was already in place for development builds.

Checklist

• The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
• The PR has a Milestone
• The PR template has been filled out
• The PR has been self reviewed
• The PR has a reviewer assigned
• The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
• The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

[gaktive]

@rak-phillip to look at this and see what needs to be ported over to 2.10.x

[richard-cox]

@rak-phillip / @gaktive I'm in discussions with Silvio about this in slack. Generally looking good for 2.9 but investigating further.

ATM not sure any change is needed for 2.10 as it avoids the min version (and just uses 'vue' but i'm not sure if that's prod/dev/something else). So we need to validate 2.10 prod builds output vue fns in performance logs

[rak-phillip]

There shouldn't be any concern for 2.10 at this point; we're not using minified builds for Vue in master.

For posterity, vue-cli-service build¹ is what handles minification in our production bundles.

Footnotes

1. https://cli.vuejs.org/guide/cli-service.html#vue-cli-service-build ↩

[richard-cox]

Just putting a blocker on this until we can test chunk size and functionality further.

I've also put it in to 2.9.5 to hopefully move into 2.9.4 if there's time

[moio]

@richard-cox about chunk size: in my 2.9.1 setup js/chunk-*.js are all exactly matching (to the byte), apart from chunk-vendors.*.js which is 31001 bytes (~30 kB) longer.

[moio]

Here is a stack trace from Chrome in the exact same situation, patched and unpatched:

Many more function names are now readable - unfortunately not 100% of them (despite correct names being there in the source maps, which can be read by clicking).

[moio]

Please let me know if anything more is need from my part.

Thanks for the reviews.

[richard-cox]

LGTM

• Validated start:prod with some BVTs
• asset size looks reasonable, checked content of old vendor chunk against new (minor minification changes
• stack traces for vue things are now useful

Just need tests to pass (i gave a bump)... and also release-2.9 branch to track 2.9.5

Edit: More info on vue builds https://v2.vuejs.org/v2/guide/installation#Explanation-of-Different-Builds

[richard-cox]

@moio i've created issues to cover the required milestones

• 2.9.5 (this one)
• 2.10.1
• 2.11.0

[richard-cox]

Switching to approved. As per other PRs still blocked on release of 2.9.4 (but once that's released this can be merged)