Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for workflows shipped with the creators package #13008

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Jan 7, 2025

Summary

Fixes #12657

Occurred changes and/or fixed issues

  • add script to do content match of creators workflows files
  • update workflows for extensions tests to run this new check

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Copy link
Member

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it may be worth to try the CI on your fork on push, just to be sure.
Anyhow, if it works for you, I see no reason to block this.

LGTM

cnotv
cnotv previously approved these changes Jan 7, 2025
jordojordo
jordojordo previously approved these changes Jan 10, 2025
@jordojordo jordojordo dismissed stale reviews from cnotv and themself via da9c1a6 January 30, 2025 19:49
@jordojordo jordojordo force-pushed the 12657-creators-wfs-tests-master branch 2 times, most recently from 51ec5e9 to 896cf7d Compare January 30, 2025 19:52
@jordojordo
Copy link
Member

I've simplified this workflow configuration while maintaining all existing functionality. Here's what changed:

  • Consolidated Workflows
    • Merged 3 separate workflows (master, release-2.9, release-2.8) into a single workflow using a matrix strategy
  • Refactored check-creators-workflows-code.sh to:
    • Use HEREDOC for cleaner template management
    • Added explicit error messaging with ::error:: commands
    • Implemented proper diff-based comparison
  • Added a dedicated aggregation job to maintain compatibility with existing Slack notifications

@aalves08 aalves08 force-pushed the 12657-creators-wfs-tests-master branch from 896cf7d to ce7c5d3 Compare February 19, 2025 15:51
@aalves08 aalves08 requested review from jordojordo and cnotv February 19, 2025 15:51
@aalves08 aalves08 merged commit 33a7b3f into rancher:master Feb 19, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create tests for workflows that we ship from the creators package
3 participants