-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for workflows shipped with the creators package #13008
Merged
aalves08
merged 2 commits into
rancher:master
from
aalves08:12657-creators-wfs-tests-master
Feb 19, 2025
Merged
Add tests for workflows shipped with the creators package #13008
aalves08
merged 2 commits into
rancher:master
from
aalves08:12657-creators-wfs-tests-master
Feb 19, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
7 tasks
cnotv
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it may be worth to try the CI on your fork on push, just to be sure.
Anyhow, if it works for you, I see no reason to block this.
LGTM
cnotv
previously approved these changes
Jan 7, 2025
jordojordo
reviewed
Jan 8, 2025
jordojordo
previously approved these changes
Jan 10, 2025
51ec5e9
to
896cf7d
Compare
I've simplified this workflow configuration while maintaining all existing functionality. Here's what changed:
|
…orkflows for extensions tests
…flows script Remove outputs from slack message
896cf7d
to
ce7c5d3
Compare
jordojordo
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12657
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist