Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket migration #13289

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Websocket migration #13289

merged 1 commit into from
Feb 18, 2025

Conversation

a-arias
Copy link
Contributor

@a-arias a-arias commented Feb 5, 2025

Summary

We have some old Python test that used to test the WebSockets for the connection inside the pods shells, to be able to send commands like list directories, create folders and validate the results, this one is going to implement the same but for cypress current automation framework

Occurred changes and/or fixed issues

Technical notes summary

rancher/qa-tasks#1350 (comment)

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@a-arias a-arias changed the title Websocket migration WIP: Websocket migration Feb 5, 2025
@izaac izaac marked this pull request as draft February 5, 2025 01:03
@richard-cox
Copy link
Member

@a-arias This is an interesting progression. Would you be able to provide some information on end goal?

@a-arias
Copy link
Contributor Author

a-arias commented Feb 5, 2025

@a-arias This is an interesting progression. Would you be able to provide some information on end goal?

hi, we have some old python test that used to test the websockets for the connection inside the pods shells, to be able to send commands like list directories, create folders and validate the results, this one is going to implement the same but for cypress current automation framework.

@izaac izaac marked this pull request as ready for review February 11, 2025 17:22
@izaac
Copy link
Contributor

izaac commented Feb 11, 2025

@a-arias this is ready for review as per our two last sync ups correct?
@yonasberhe23 @IsaSih could you take a look at this too?

@izaac izaac requested review from yonasberhe23 and IsaSih February 11, 2025 17:23
@izaac izaac added this to the v2.11.0 milestone Feb 11, 2025
@izaac izaac added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Feb 11, 2025
@izaac izaac changed the title WIP: Websocket migration Websocket migration Feb 11, 2025
@izaac
Copy link
Contributor

izaac commented Feb 11, 2025

cypress.config.ts Outdated Show resolved Hide resolved
@izaac
Copy link
Contributor

izaac commented Feb 11, 2025

@a-arias I think the jenkins cypress.config has to be updated too for the Jenkins CI, https://github.com/rancher/dashboard/blob/master/cypress/jenkins/cypress.config.jenkins.ts

@a-arias a-arias force-pushed the qa_websocket_migration branch from 27de907 to b266080 Compare February 15, 2025 01:20
@yonasberhe23 yonasberhe23 self-requested a review February 18, 2025 19:59
@a-arias a-arias force-pushed the qa_websocket_migration branch from ca5f0c9 to 69ed75d Compare February 18, 2025 20:52
@a-arias a-arias force-pushed the qa_websocket_migration branch from 69ed75d to 2d22440 Compare February 18, 2025 20:55
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paired reviewed offline. Troubleshooting this isn't working as expected when running on the same Rancher node as it's done in Actions. Tagging it for Jenkins.

@a-arias a-arias merged commit bc9ada5 into rancher:master Feb 18, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants