-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Websocket migration #13289
Websocket migration #13289
Conversation
@a-arias This is an interesting progression. Would you be able to provide some information on end goal? |
hi, we have some old python test that used to test the websockets for the connection inside the pods shells, to be able to send commands like list directories, create folders and validate the results, this one is going to implement the same but for cypress current automation framework. |
@a-arias this is ready for review as per our two last sync ups correct? |
these are the original tests: https://github.com/rancher/rancher/blob/main/tests/validation/tests/v3_api/test_websocket.py |
cypress/e2e/tests/pages/explorer/dashboard/websockets/connection.spec.ts
Outdated
Show resolved
Hide resolved
@a-arias I think the jenkins cypress.config has to be updated too for the Jenkins CI, https://github.com/rancher/dashboard/blob/master/cypress/jenkins/cypress.config.jenkins.ts |
cypress/e2e/tests/pages/explorer/dashboard/websockets/connection.spec.ts
Outdated
Show resolved
Hide resolved
27de907
to
b266080
Compare
cypress/e2e/tests/pages/explorer/dashboard/websockets/connection.spec.ts
Show resolved
Hide resolved
ca5f0c9
to
69ed75d
Compare
69ed75d
to
2d22440
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paired reviewed offline. Troubleshooting this isn't working as expected when running on the same Rancher node as it's done in Actions. Tagging it for Jenkins.
Summary
We have some old Python test that used to test the WebSockets for the connection inside the pods shells, to be able to send commands like list directories, create folders and validate the results, this one is going to implement the same but for cypress current automation framework
Occurred changes and/or fixed issues
Technical notes summary
rancher/qa-tasks#1350 (comment)
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist