Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zh hant language #13290

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Infinirc-RickyChen
Copy link

@Infinirc-RickyChen Infinirc-RickyChen commented Feb 5, 2025

Summary

Add Traditional Chinese (zh-Hant) localization support to Rancher Dashboard

Fixes: #13415

Occurred changes and/or fixed issues

  • Added Traditional Chinese language support to the Rancher Dashboard UI
  • Created new language file shell/assets/translations/zh-hant.yaml
  • Added Traditional Chinese translations for harvester-manager package
  • Updated language selection menu to include Traditional Chinese option
  • Ensured consistent translation of technical terms across the UI

Technical notes summary

  • Added new locale code 'zh-Hant' with proper language configuration
  • Maintained existing translation structure for consistency
  • Ensured proper handling of special characters and formatting
  • Followed existing i18n implementation patterns

Screenshot/Video

截圖 2025-02-05 上午10 20 33 截圖 2025-02-05 上午10 20 43 截圖 2025-02-05 下午3 22 07

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@Infinirc-RickyChen Infinirc-RickyChen changed the title Feature/add zh hant Add zh hant language Feb 5, 2025
@richard-cox richard-cox added this to the v2.11.0 milestone Feb 14, 2025
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a110605 would you be able to review or locate someone who can confirm the translations are ok (mainly that there's nothing controversial or inappropriate and that they are roughly correct)?

@@ -190,7 +190,7 @@
"lodash.debounce": "4.0.8",
"nodemon": "2.0.22",
"nyc": "15.1.0",
"start-server-and-test": "2.0.10",
"start-server-and-test": "1.13.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come this was needed?

<th />
</tr>
</thead>
<tr>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like this and a few other similar changes below are reverts of recent changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Traditional Chinese (zh-Hant) localization
2 participants