Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable service triggers on staging #498

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

davidcassany
Copy link
Contributor

@davidcassany davidcassany commented Aug 23, 2023

Since all services are set to manual or buildtime in staging, triggering services has no effect. Staging has to be updated manually.

Related to rancher/elemental#971 and rancher/elemental-toolkit#1817

@davidcassany davidcassany requested a review from a team as a code owner August 23, 2023 12:35
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f1f3c32) 51.50% compared to head (7a6c748) 51.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   51.50%   51.50%           
=======================================
  Files          41       41           
  Lines        5551     5551           
=======================================
  Hits         2859     2859           
  Misses       2443     2443           
  Partials      249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@kkaempf kkaempf enabled auto-merge (squash) August 24, 2023 13:47
@kkaempf kkaempf merged commit c90c1c8 into rancher:main Aug 24, 2023
15 checks passed
@davidcassany davidcassany deleted the disable_staging_automation branch June 26, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants