Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable local plan for elemental-system-agent #534

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

ldevulder
Copy link
Contributor

As local plan is not used, only remote.

@ldevulder ldevulder added the area/operator operator related changes label Oct 6, 2023
@ldevulder ldevulder self-assigned this Oct 6, 2023
@ldevulder ldevulder requested a review from a team as a code owner October 6, 2023 10:46
@ldevulder ldevulder force-pushed the disable-localenabled-elemental-system-agent branch from 7b9958c to 9ca781c Compare October 6, 2023 12:13
@github-actions github-actions bot added the area/tests test related changes label Oct 6, 2023
@ldevulder ldevulder force-pushed the disable-localenabled-elemental-system-agent branch 4 times, most recently from 7af5005 to 7d56074 Compare October 6, 2023 12:48
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b359b1e) 53.65% compared to head (e5c4860) 53.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #534   +/-   ##
=======================================
  Coverage   53.65%   53.65%           
=======================================
  Files          39       39           
  Lines        5690     5690           
=======================================
  Hits         3053     3053           
  Misses       2368     2368           
  Partials      269      269           
Files Coverage Δ
pkg/install/install.go 58.82% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ldevulder ldevulder force-pushed the disable-localenabled-elemental-system-agent branch from 7d56074 to f2f47d2 Compare October 6, 2023 12:56
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me 👍 I don't think we need local plans in any way as of today.

As local plan is not used, only remote.

Signed-off-by: Loic Devulder <[email protected]>
@ldevulder ldevulder force-pushed the disable-localenabled-elemental-system-agent branch from f2f47d2 to e5c4860 Compare October 6, 2023 18:16
@ldevulder ldevulder merged commit 961b0c5 into main Oct 9, 2023
@ldevulder ldevulder deleted the disable-localenabled-elemental-system-agent branch October 9, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/operator operator related changes area/tests test related changes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants