-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement picking dynamic installation device #561
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/operator
operator related changes
area/register
register related changes
area/tests
test related changes
labels
Nov 2, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
==========================================
- Coverage 54.45% 54.27% -0.19%
==========================================
Files 39 39
Lines 5891 6005 +114
==========================================
+ Hits 3208 3259 +51
- Misses 2409 2466 +57
- Partials 274 280 +6 ☔ View full report in Codecov by Sentry. |
frelon
force-pushed
the
device-selector
branch
3 times, most recently
from
November 2, 2023 09:44
ef6f5b5
to
84cb7fa
Compare
frelon
force-pushed
the
device-selector
branch
from
November 15, 2023 08:01
84cb7fa
to
f352761
Compare
davidcassany
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks great to me 👍
Signed-off-by: Fredrik Lönnegren <[email protected]>
This commit adds the implementation for picking the installation device during registration based on a deviceSelector in the MachineRegistration. Signed-off-by: Fredrik Lönnegren <[email protected]>
frelon
force-pushed
the
device-selector
branch
from
November 20, 2023 16:28
f352761
to
896195e
Compare
davidcassany
pushed a commit
that referenced
this pull request
Nov 23, 2023
* Add DeviceSelector types Signed-off-by: Fredrik Lönnegren <[email protected]> * Implement device-selector This commit adds the implementation for picking the installation device during registration based on a deviceSelector in the MachineRegistration. Signed-off-by: Fredrik Lönnegren <[email protected]> --------- Signed-off-by: Fredrik Lönnegren <[email protected]> (cherry picked from commit 8cf8b03)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/operator
operator related changes
area/register
register related changes
area/tests
test related changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the implementation for picking the installation device during registration based on a deviceSelector in the MachineRegistration.
Pasting some example registrations for different use-cases:
Fixes #543