Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify all chart files under .obs/charfile #572

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

davidcassany
Copy link
Contributor

@davidcassany davidcassany commented Nov 24, 2023

This PR removes the charts folder in favor of the .obs/chartfile folder. Now only OBS charts are in place. make charts is still functional on local environments as it essentially takes the OBS files and manually applies required substitutions.

@davidcassany davidcassany requested a review from a team as a code owner November 24, 2023 15:09
@github-actions github-actions bot added the area/build build related changes label Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f1d44d8) 54.13% compared to head (0c5a036) 54.13%.
Report is 1 commits behind head on main.

❗ Current head 0c5a036 differs from pull request most recent head a2a8795. Consider uploading reports for the commit a2a8795 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #572   +/-   ##
=======================================
  Coverage   54.13%   54.13%           
=======================================
  Files          39       39           
  Lines        6005     6005           
=======================================
  Hits         3251     3251           
  Misses       2472     2472           
  Partials      282      282           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidcassany davidcassany self-assigned this Nov 28, 2023
Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup is always good 😆

@davidcassany davidcassany merged commit ba7ce1f into rancher:main Nov 28, 2023
13 checks passed
@davidcassany davidcassany deleted the unify_chart_files branch November 28, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build build related changes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants