Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning if both device and device-selector set #574

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Add warning if both device and device-selector set #574

merged 1 commit into from
Nov 27, 2023

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Nov 27, 2023

No description provided.

@frelon frelon requested a review from a team as a code owner November 27, 2023 08:33
@github-actions github-actions bot added the area/operator operator related changes label Nov 27, 2023
@frelon frelon mentioned this pull request Nov 27, 2023
Merged
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f1d44d8) 54.13% compared to head (6b7f7b9) 54.11%.

Files Patch % Lines
pkg/install/install.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
- Coverage   54.13%   54.11%   -0.03%     
==========================================
  Files          39       39              
  Lines        6005     6008       +3     
==========================================
  Hits         3251     3251              
- Misses       2472     2474       +2     
- Partials      282      283       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

davidcassany
davidcassany approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davidcassany davidcassany merged commit 4b5e46c into rancher:main Nov 27, 2023
17 checks passed
@frelon frelon deleted the device-selector-warn branch November 27, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidcassany davidcassany davidcassany approved these changes

Assignees
No one assigned
Labels
area/operator operator related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frelon @davidcassany