Fix channel sync bug racy symptom #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During upgrades we have a race-condition for the ManagedOSVersionChannels. This commit checks to see if a ManagedOSVersionChannel syncer pod was created with another image than the provided elemental-operator and if true, will delete the old pod and recreate the syncer pod. Signed-off-by: Fredrik Lönnegren <[email protected]>
Closed
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
==========================================
- Coverage 54.11% 54.07% -0.04%
==========================================
Files 39 39
Lines 6008 6012 +4
==========================================
Hits 3251 3251
- Misses 2474 2477 +3
- Partials 283 284 +1 ☔ View full report in Codecov by Sentry. |
davidcassany
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Looks good to me.
If this alone solves the issue I prefer this change over #578
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During upgrades we have a race-condition for the ManagedOSVersionChannels.
This commit checks to see if a ManagedOSVersionChannel syncer pod was created with another image than the provided elemental-operator and if true, will delete the old pod and recreate the syncer pod.