Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elemental-operator registration cleanups #689

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

fgiudici
Copy link
Member

Drops support to elemental-register clients < v0.5.0

@fgiudici fgiudici requested a review from a team as a code owner March 20, 2024 08:35
@github-actions github-actions bot added the area/operator operator related changes label Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 54.79%. Comparing base (f07a038) to head (04ad2b2).
Report is 63 commits behind head on main.

❗ Current head 04ad2b2 differs from pull request most recent head ab5ff06. Consider uploading reports for the commit ab5ff06 to get more accurate results

Files Patch % Lines
pkg/server/api_registration.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
+ Coverage   53.79%   54.79%   +1.00%     
==========================================
  Files          40       40              
  Lines        6073     5013    -1060     
==========================================
- Hits         3267     2747     -520     
+ Misses       2519     1974     -545     
- Partials      287      292       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@anmazzotti anmazzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Signed-off-by: Francesco Giudici <[email protected]>
Drop some very old code (pre-kubebuilder).

Signed-off-by: Francesco Giudici <[email protected]>
@fgiudici fgiudici force-pushed the registration_cleanups branch from 04ad2b2 to ab5ff06 Compare March 21, 2024 16:05
@fgiudici
Copy link
Member Author

Airgap failing as the dev charts channel not working.

@fgiudici fgiudici merged commit 070b538 into rancher:main Mar 21, 2024
22 of 23 checks passed
davidcassany pushed a commit that referenced this pull request Mar 22, 2024
* registration: fix typo
* registration: drop support to elemental-register < v0.5.0

Signed-off-by: Francesco Giudici <[email protected]>
(cherry picked from commit 070b538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/operator operator related changes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants