Add dmidecode as Recommends to elemental-register #702
Conversation
…ckage Signed-off-by: Andrea Mazzotti <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
==========================================
+ Coverage 53.79% 58.02% +4.22%
==========================================
Files 40 40
Lines 6073 4974 -1099
==========================================
- Hits 3267 2886 -381
+ Misses 2519 1779 -740
- Partials 287 309 +22 ☔ View full report in Codecov by Sentry. |
| @@ -59,6 +59,9 @@ BuildRoot: %{_tmppath}/%{name}-%{version}-build | |||
| %package -n elemental-register | |||
| Summary: The registration client | |||
|
|
|||
| Requires: dmidecode | |||
| Requires: libopenssl1_1 | |||
There was a problem hiding this comment.
Libraries must not appear in Requires. The build process has tooling in place to automatically find library dependencies.
| @@ -59,6 +59,9 @@ BuildRoot: %{_tmppath}/%{name}-%{version}-build | |||
| %package -n elemental-register | |||
| Summary: The registration client | |||
|
|
|||
| Requires: dmidecode | |||
There was a problem hiding this comment.
Not sure about this. Is this really required (in the sense of: program won't work / will crash without) ?
Otherwise it should be a Recommends 😉
There was a problem hiding this comment.
Technically we will fail to register, because the no-smbios Registration flag is off by default.
However it should be possible for users to do a --no-recommends install, using the no-smbios flag if they need to. So this is probably the best approach.
Thank you.
Signed-off-by: Andrea Mazzotti <[email protected]>
kkaempf
changed the title
No description provided.