Let elemental-register digest system hardware data #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Mazzotti <[email protected]>
github-actions
bot
added
area/operator
Signed-off-by: Andrea Mazzotti <[email protected]>
fgiudici
reviewed
Jun 4, 2024
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
anmazzotti
added a commit
to anmazzotti/elemental-operator
that referenced
this pull request
Jun 5, 2024
* Let elemental-register digest system hardware data (SystemData V2) Signed-off-by: Andrea Mazzotti <[email protected]>
anmazzotti
added a commit
that referenced
this pull request
Jun 5, 2024
* Let elemental-register digest system hardware data (SystemData V2) Signed-off-by: Andrea Mazzotti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should remove the
elemental-operatordependency on ghw library, making theelemental-registerclient do the conversion.The implementation is backward compatible, tested it with a
1.4.2version of the elemental-register and it works as expected.This is a solution for #733 and if integrated, it should be backported to 1.6.x in order to close that issue.