Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.6.x backport] Flag no longer in sync ManagedOSVersions #752

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

anmazzotti
Copy link
Contributor

  • Flag no longer in sync ManagedOSVersions

* Flag no longer in sync ManagedOSVersions

Signed-off-by: Andrea Mazzotti <[email protected]>
@anmazzotti anmazzotti requested a review from a team as a code owner June 12, 2024 13:42
@github-actions github-actions bot added the area/tests test related changes label Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (v1.6.x@b5b0f4c). Learn more about missing BASE report.

Files Patch % Lines
controllers/managedosversionchannel_controller.go 72.22% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             v1.6.x     #752   +/-   ##
=========================================
  Coverage          ?   57.44%           
=========================================
  Files             ?       41           
  Lines             ?     5090           
  Branches          ?        0           
=========================================
  Hits              ?     2924           
  Misses            ?     1853           
  Partials          ?      313           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anmazzotti anmazzotti merged commit d71e78b into rancher:v1.6.x Jun 17, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests test related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants