Improve error logging

Signed-off-by: David Cassany <[email protected]>

cmd/build-disk.go

@@ -86,7 +86,12 @@ func NewBuildDisk(root *cobra.Command, addCheckRoot bool) *cobra.Command {
 				cfg.Logger.Errorf("failed to initialize build disk action: %v", err)
 				return err
 			}
-			return builder.BuildDiskRun()
+
+			err = builder.BuildDiskRun()
+			if err != nil {
+				cfg.Logger.Errorf("build-disk command failed: %v", err)
+			}
+			return err
 		},
 	}
 	root.AddCommand(c)

cmd/build-iso.go

@@ -126,7 +126,12 @@ func NewBuildISO(root *cobra.Command, addCheckRoot bool) *cobra.Command {
 			}
 
 			buildISO := action.NewBuildISOAction(cfg, spec)
-			return buildISO.Run()
+			err = buildISO.Run()
+			if err != nil {
+				cfg.Logger.Errorf("build-iso command failed: %v", err)
+			}
+
+			return err
 		},
 	}
 

cmd/cloud-init.go

@@ -62,6 +62,10 @@ func NewCloudInitCmd(root *cobra.Command) *cobra.Command {
 			}
 
 			err = cfg.CloudInitRunner.Run(stage, args...)
+			if err != nil {
+				cfg.Logger.Errorf("cloud-init command failed: %v")
+			}
+
 			return elementalError.NewFromError(err, elementalError.CloudInitRunStage)
 		},
 	}

cmd/init.go

@@ -59,7 +59,11 @@ func InitCmd(root *cobra.Command) *cobra.Command {
 			}
 
 			cfg.Logger.Infof("Initializing system...")
-			return action.RunInit(cfg, spec)
+			err = action.RunInit(cfg, spec)
+			if err != nil {
+				cfg.Logger.Errorf("init command failed: %v", err)
+			}
+			return err
 		},
 	}
 	root.AddCommand(c)

cmd/install.go

@@ -90,7 +90,11 @@ func NewInstallCmd(root *cobra.Command, addCheckRoot bool) *cobra.Command {
 				cfg.Logger.Errorf("failed to initialize install action: %v", err)
 				return err
 			}
-			return install.Run()
+			err = install.Run()
+			if err != nil {
+				cfg.Logger.Errorf("install command failed: %v", err)
+			}
+			return err
 		},
 	}
 	firmType := newEnumFlag([]string{types.EFI}, types.EFI)

cmd/mount.go

@@ -53,7 +53,12 @@ func NewMountCmd(root *cobra.Command) *cobra.Command {
 			}
 
 			cfg.Logger.Info("Mounting system...")
-			return action.RunMount(cfg, spec)
+			err = action.RunMount(cfg, spec)
+			if err != nil {
+				cfg.Logger.Errorf("mount command failed: %v", err)
+			}
+
+			return err
 		},
 	}
 	root.AddCommand(c)

cmd/reset.go

@@ -72,7 +72,13 @@ func NewResetCmd(root *cobra.Command, addCheckRoot bool) *cobra.Command {
 				cfg.Logger.Errorf("failed to initialize reset action: %v", err)
 				return err
 			}
-			return reset.Run()
+
+			err = reset.Run()
+			if err != nil {
+				cfg.Logger.Errorf("reset command failed: %v", err)
+			}
+
+			return err
 		},
 	}
 	root.AddCommand(c)

cmd/upgrade-recovery.go

@@ -73,7 +73,12 @@ func NewUpgradeRecoveryCmd(root *cobra.Command, addCheckRoot bool) *cobra.Comman
 				return err
 			}
 
-			return upgrade.Run()
+			err = upgrade.Run()
+			if err != nil {
+				cfg.Logger.Errorf("upgrade-recovery command failed: %v", err)
+			}
+
+			return err
 		},
 	}
 	root.AddCommand(c)

cmd/upgrade.go

@@ -81,7 +81,12 @@ func NewUpgradeCmd(root *cobra.Command, addCheckRoot bool) *cobra.Command {
 				return err
 			}
 
-			return upgrade.Run()
+			err = upgrade.Run()
+			if err != nil {
+				cfg.Logger.Errorf("upgrade command failed: %v", err)
+			}
+
+			return err
 		},
 	}
 	root.AddCommand(c)