strict elemental setup #2201
strict elemental setup #2201
Conversation
frelon
commented
Oct 2, 2024
frelon
commented
- Use --strict flag in elemental-setup services
- Set SilenceUsage for run-stage command
frelon
force-pushed
the
strict-elemental-setup
branch
from
196c69c
to
e10fd8a
Compare
There was a problem hiding this comment.
Would be nice having some integration tests for that. What about setting some cloud-config in installation tests we know it will fail, so that we can check it still boots but on a degraded state, as some elemental-setup-* service failed. Even more, ideally we should be capable to see the failure in journalctl.
Alternatively, we also use such a process for the fallback test. Imagine we set a health check test that reports error if systemd is on degraded state.
Essentially, we should define the behavior we expect on a cloud-config failure and then add an integration tests to exercise it.
|
@davidcassany This is true, I will look into some tests in this PR before merging! |
frelon
force-pushed
the
strict-elemental-setup
branch
from
e10fd8a
to
d09e23f
Compare
Pull request was converted to draft
frelon
force-pushed
the
strict-elemental-setup
branch
2 times, most recently
from
35eebe5
to
e50fa11
Compare
I am trying to implement a test for that, I think it should be relatively straight forward and I think this would cover the most important from integration test perspective. |
The default behavior has been to hide any errors and only log warnings. Using the --strict flag will ensure any yip errors are actually reported. Signed-off-by: Fredrik Lönnegren <[email protected]>
This ensures we do not show the usage text for errors caught during yip execution. Signed-off-by: Fredrik Lönnegren <[email protected]>
Signed-off-by: David Cassany <[email protected]>
…s a degraded systemd status Signed-off-by: David Cassany <[email protected]>
davidcassany
force-pushed
the
strict-elemental-setup
branch
from
e50fa11
to
8d609b2
Compare
|
Checked manually that failures show up in journal, I don't think we need explicit test for that. |
