Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #2223

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Update dependencies #2223

merged 2 commits into from
Nov 6, 2024

Conversation

davidcassany
Copy link
Contributor

No description provided.

@davidcassany davidcassany requested a review from a team as a code owner November 6, 2024 08:24
@@ -42,6 +42,10 @@ Requires: xorriso >= 1.5
Requires: mtools
Requires: util-linux
Requires: gptfdisk
Requires: dracut
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required by elemental init to create the initrd

@@ -42,6 +42,10 @@ Requires: xorriso >= 1.5
Requires: mtools
Requires: util-linux
Requires: gptfdisk
Requires: dracut
Requires: grub2-common
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provides grub2-editenv required to install and upgrade.

@@ -42,6 +42,10 @@ Requires: xorriso >= 1.5
Requires: mtools
Requires: util-linux
Requires: gptfdisk
Requires: dracut
Requires: grub2-common
Requires: squashfs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required to handle recovery image as squashfs and to create ISOs

Requires: dracut
Requires: grub2-common
Requires: squashfs
Requires: util-linux-systemd
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provides findmnt which is used in elemental mount command and in snapshotter.


inst_simple "/etc/elemental/config.yaml"

# Include utilities required for elemental-setup services,
# probably a devoted dracut module makes sense
inst_multiple -o \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was actually a an elemental-setup dracut module, this comment is was so outdated and all this dependencies should have been moved to the devoted dracut module.

@@ -24,15 +24,10 @@ install() {
declare systemdsystemunitdir=${systemdsystemunitdir}

inst_multiple \
mount mountpoint sort rmdir findmnt rsync cut realpath basename lsblk
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is the elemental mount command this dracut module doesn't require most of the pieces it used to as most of the logic simply moved to elemental mount.

Copy link
Contributor

@frelon frelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@frelon frelon merged commit eb77a4c into rancher:main Nov 6, 2024
28 checks passed
@davidcassany davidcassany deleted the update_dependencies branch November 6, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants