Fixes squashfs images creation #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcassany
force-pushed
the
fix_creating_squashfs_images
branch
2 times, most recently
from
856838f
to
bf0edb3
Compare
If upgrading from a container including the root of the host mounted in /host the upgrade process does not exclude the /host path and other stateful paths such as /run. This commit sets the default excludes used in rsync calls to also apply for mksquashfs. Signed-off-by: David Cassany <[email protected]>
davidcassany
force-pushed
the
fix_creating_squashfs_images
branch
from
bf0edb3
to
a56f1d2
Compare
frelon
approved these changes
Nov 12, 2024
This commit defines static methods for excluded paths in sync operations. One method for relative paths and another one with the same result rooted to a given path. It also uses wildcards to only exclude certain directories content while keeping the directory itself. Signed-off-by: David Cassany <[email protected]>
Signed-off-by: David Cassany <[email protected]>
davidcassany
added a commit
to davidcassany/elemental-toolkit
that referenced
this pull request
Nov 13, 2024
* Fixes squashfs images creation (bsc#1233289) If upgrading from a container including the root of the host mounted in /host the upgrade process does not exclude the /host path and other stateful paths such as /run. This commit sets the default excludes used in rsync calls to also apply for mksquashfs. Signed-off-by: David Cassany <[email protected]> * Define static method for default exclude relative paths This commit defines static methods for excluded paths in sync operations. One method for relative paths and another one with the same result rooted to a given path. It also uses wildcards to only exclude certain directories content while keeping the directory itself. Signed-off-by: David Cassany <[email protected]> * Add some additional unit tests for rsync wrappers Signed-off-by: David Cassany <[email protected]> --------- Signed-off-by: David Cassany <[email protected]> (cherry picked from commit 527c12d)
davidcassany
added a commit
to davidcassany/elemental-toolkit
that referenced
this pull request
Nov 13, 2024
* Fixes squashfs images creation (bsc#1233289) If upgrading from a container including the root of the host mounted in /host the upgrade process does not exclude the /host path and other stateful paths such as /run. This commit sets the default excludes used in rsync calls to also apply for mksquashfs. Signed-off-by: David Cassany <[email protected]> * Define static method for default exclude relative paths This commit defines static methods for excluded paths in sync operations. One method for relative paths and another one with the same result rooted to a given path. It also uses wildcards to only exclude certain directories content while keeping the directory itself. Signed-off-by: David Cassany <[email protected]> * Add some additional unit tests for rsync wrappers Signed-off-by: David Cassany <[email protected]> --------- Signed-off-by: David Cassany <[email protected]> (cherry picked from commit 527c12d)
davidcassany
added a commit
that referenced
this pull request
Nov 13, 2024
* Fixes squashfs images creation (bsc#1233289) If upgrading from a container including the root of the host mounted in /host the upgrade process does not exclude the /host path and other stateful paths such as /run. This commit sets the default excludes used in rsync calls to also apply for mksquashfs. Signed-off-by: David Cassany <[email protected]> * Define static method for default exclude relative paths This commit defines static methods for excluded paths in sync operations. One method for relative paths and another one with the same result rooted to a given path. It also uses wildcards to only exclude certain directories content while keeping the directory itself. Signed-off-by: David Cassany <[email protected]> * Add some additional unit tests for rsync wrappers Signed-off-by: David Cassany <[email protected]> --------- Signed-off-by: David Cassany <[email protected]> (cherry picked from commit 527c12d)
davidcassany
added a commit
that referenced
this pull request
Nov 13, 2024
* Fixes squashfs images creation (bsc#1233289) If upgrading from a container including the root of the host mounted in /host the upgrade process does not exclude the /host path and other stateful paths such as /run. This commit sets the default excludes used in rsync calls to also apply for mksquashfs. Signed-off-by: David Cassany <[email protected]> * Define static method for default exclude relative paths This commit defines static methods for excluded paths in sync operations. One method for relative paths and another one with the same result rooted to a given path. It also uses wildcards to only exclude certain directories content while keeping the directory itself. Signed-off-by: David Cassany <[email protected]> * Add some additional unit tests for rsync wrappers Signed-off-by: David Cassany <[email protected]> --------- Signed-off-by: David Cassany <[email protected]> (cherry picked from commit 527c12d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If upgrading from a container including the root of the host mounted in /host the upgrade process does not exclude the /host path and other stateful paths such as /run.
This commit sets the default excludes used in rsync calls to also apply for mksquashfs.