Fix 2.9 tests #164
Merged
Fix 2.9 tests #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, but not sure I understand what is being fixed here.
|
|
Another 2.9 CI run: |
FTR, after understanding the issue and discussing offline I understood the test failed due to a legit bug; therefore it seems nice to leave as it is so it can capture when it is fixed and perhaps simply add a check to ensure services are deleted propperly |
Signed-off-by: Satyajit Bulage <[email protected]>
Signed-off-by: Satyajit Bulage <[email protected]>
Signed-off-by: Satyajit Bulage <[email protected]>
Signed-off-by: Satyajit Bulage <[email protected]>
mmartin24
reviewed
Jul 5, 2024
mmartin24
reviewed
Jul 5, 2024
|
Thanks @mmartin24 for nice suggestions 👍 |
mmartin24
reviewed
Jul 5, 2024
Signed-off-by: Satyajit Bulage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Current 2.9 CI is failing for correctDrift test cases (79,80). The reason for failure is ConfigMap is getting deleted but service is not being removed rather it is being re-created. This behavior is observed after GitRepo deletion.
Solution: Used individual paths to ConfigMaps and Services so GitRepo will not install both applications simultaneously. Also, their deletion will be performed separately.
Changes made in the PR: Path is added to individual tests, Removed extra indentation.
While investigating this I found problem: Bundle is not getting removed after deleting GitRepo when multiple paths are used. (rancher/fleet#2586)