Apply suggestions from code review

Co-authored-by: Corentin Néau <[email protected]>
rancher · Jul 3, 2024 · 9711362 · 9711362
1 parent 75193c1
commit 9711362
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/.github/workflows/e2e-ci.yml b/.github/workflows/e2e-ci.yml
@@ -96,16 +96,15 @@ jobs:
         env:
           FLEET_E2E_NS: fleet-local
         run: |
-          # 1. Run test cases not needing infra
+          # Run test cases not needing infra, skipping sharding tests as well
           ginkgo --github-output --label-filter='!infra-setup && !sharding' e2e/single-cluster e2e/keep-resources e2e/drift
       -
         name: E2E Sharding/Metrics Tests
         if: ${{ matrix.test_type.name == 'sharding' }}
         env:
           FLEET_E2E_NS: fleet-local
         run: |
-          ginkgo --github-output --label-filter='!infra-setup && sharding' e2e/single-cluster
-          # 2. Run tests for metrics
+          ginkgo --github-output --label-filter='sharding' e2e/single-cluster
           ginkgo --github-output e2e/metrics
           SHARD=shard1 ginkgo --github-output e2e/metrics
       -
@@ -130,7 +129,7 @@ jobs:
         run: |
           export CI_OCI_CERTS_DIR="$(git rev-parse --show-toplevel)/FleetCI-RootCA"
 
-          # 3. Run tests requiring only the git server
+          # Run tests requiring only the git server
           e2e/testenv/infra/infra setup --git-server=true
           ginkgo --github-output --label-filter='infra-setup && !helm-registry && !oci-registry' e2e/single-cluster/