Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition between gitops and gitrepo controller #2435

Closed
4 tasks
manno opened this issue May 16, 2024 · 2 comments
Closed
4 tasks

Race condition between gitops and gitrepo controller #2435

manno opened this issue May 16, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@manno
Copy link
Member

manno commented May 16, 2024

The gitops gitjob controller needs RBAC from the gitrepo controller.

Move from gitrepo to gitops controller:

  • AuthorizeAndAssignDefaults
  • rbac creation
  • helm values check
  • NewTargetsConfigMap

Basically, only the display/summary status updates remain in the gitrepo controller.

  • SetStatusFromResourceKey
  • UpdateDisplayState
  • SetStatusFromBundles
  • SetStatusFromBundleDeployments
  • gitrepo.Status.Display.ReadyBundleDeployments =

Can we improve the condition updates, so both controllers don't conflict on the same condition?

@manno manno added this to Fleet May 16, 2024
@manno manno converted this from a draft issue May 16, 2024
@manno manno added this to the v2.9.0 milestone May 16, 2024
@manno manno added the kind/bug label May 16, 2024
@manno
Copy link
Member Author

manno commented May 22, 2024

Possible duplicate of #2343

@0xavi0
Copy link
Contributor

0xavi0 commented Jun 25, 2024

There is no longer race conditions between those 2 controllers, because #2537 merges the whole functionality into the gitops controller.
The GitRepo controller does not exist anymore.

@0xavi0 0xavi0 closed this as completed Jun 25, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Fleet Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants