Moves functionality from gitrepo to gitjob controller #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruiz14
reviewed
May 31, 2024
0xavi0
force-pushed
the
2435-gitopts-gitrepo-controllers
branch
5 times, most recently
from
9f85170 to
84d478d
Compare
weyfonk
reviewed
Jun 3, 2024
0xavi0
force-pushed
the
2435-gitopts-gitrepo-controllers
branch
from
84d478d to
4a6411a
Compare
weyfonk
reviewed
Jun 4, 2024
0xavi0
force-pushed
the
2435-gitopts-gitrepo-controllers
branch
2 times, most recently
from
6f0300e to
ee3135c
Compare
weyfonk
previously approved these changes
Jun 5, 2024
manno
reviewed
Jun 5, 2024
| @@ -59,14 +62,18 @@ var _ = BeforeSuite(func() { | |||
| Expect(err).NotTo(HaveOccurred()) | |||
| Expect(k8sClient).NotTo(BeNil()) | |||
|
|
|||
| mgr, err := ctrl.NewManager(cfg, ctrl.Options{ | |||
| mgr, err := ctrlruntime.NewManager(cfg, ctrlruntime.Options{ | |||
There was a problem hiding this comment.
Oh, yeah, I forgot to change that back to ctrl.
There was already a variable around called ctrl and they were clashing.
It should be back to the standard ctrl now
Moves the following from `gitrepo` controller to `gitjob` controller: * AuthorizeAndAssignDefaults * RBAC resources creation * Helm secrets check * NewTargetsConfigMap The `gitrepo` controller still purges `bundles` and `bundledeployments` on `gitrepo` deletion and handles the status coming from `bundles` and `bundledeployments` Some functionality that was shared between both controllers has been moved to a common package to avoid code repetition. Signed-off-by: Xavi Garcia <[email protected]>
0xavi0
force-pushed
the
2435-gitopts-gitrepo-controllers
branch
from
ee3135c to
ac31217
Compare
weyfonk
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the following from
gitrepocontroller togitjobcontroller:The
gitrepocontroller still purgesbundlesandbundledeploymentsongitrepodeletion and handles the status coming frombundlesandbundledeploymentsSome functionality that was shared between both controllers has been moved to a common package to avoid code repetition.
Refers to: #2435