Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to gitops controller #2530

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Add metrics to gitops controller #2530

merged 1 commit into from
Jun 19, 2024

Conversation

Tommy12789
Copy link
Contributor

Refers to #2450

Introduced a new service for gitops metrics

@Tommy12789 Tommy12789 changed the title first version Add metrics to gitops controller Jun 17, 2024
@Tommy12789 Tommy12789 marked this pull request as ready for review June 19, 2024 09:11
@Tommy12789 Tommy12789 requested a review from a team as a code owner June 19, 2024 09:11
Copy link
Contributor

@p-se p-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@0xavi0
Copy link
Contributor

0xavi0 commented Jun 19, 2024

Don't we also need to expose the port and name it in the gitjob deployment?

For example:

spec:
      serviceAccountName: gitjob
      containers:
        - image: "{{ template "system_default_registry" $ }}{{ $.Values.image.repository }}:{{ $.Values.image.tag }}"
          name: gitjob
          {{- if $.Values.metrics.enabled }}
          ports:
          - containerPort: 8081
            name: metrics
          {{- end }}
          args:
          - fleetcontroller
          - gitjob

@p-se p-se merged commit 0080e61 into rancher:main Jun 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants