Fix extraEnv in gitjob controller template

[manno]

Setting debug to false would put the additional env vars outside the env block.

% helm template --set 'extraEnv[0].name="foo"' --set 'extraEnv[0].value="bar"' fleet charts/fleet
Error: YAML parse error on fleet/templates/deployment_gitjob.yaml: error converting YAML to JSON: yaml: line 47: did not find expected key

Use --debug flag to render out invalid YAML

[weyfonk]

🦅 👁️ !

[manno]

I'm adding an initial setup for https://github.com/helm/chart-testing/blob/main/doc/ct_lint.md

[weyfonk]

Would this file, and other files under charts/fleet{-agent,}/ci end up being packaged in our charts?
Should we add .helmignore files to those charts to prevent that?

Apart from that, I'm sligthly concerned about the maintenance overhead of those values files when we add new features involving such values: it looks likely to me that we may forget to update at least some of them to reflect the latest available values.

[manno]

Thanks, added those .helmignore files. The actual values in those files don't matter much. I think chart-testing just checks that the result is valid YAML. Not sure if we will ever be able to cover all combinations, but at least this bug would have been catched by the one file with "debug: false".