Propagate drift correction error to bundle deployment status #2792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prints the actual modified status and conditions of a bundle deployment when one of them differs from the expectation, which helps troubleshoot mismatches.
When drift correction fails, the Fleet agent now populates the error in the bundle deployment's status, which will help make those errors visible and users aware of them.
manno
approved these changes
Sep 11, 2024
weyfonk
added a commit
to weyfonk/fleet
that referenced
this pull request
Sep 11, 2024
…#2792) * Propagate drift correction error to bundle deployment status When drift correction fails, the Fleet agent now populates the error in the bundle deployment's status, which will help make those errors visible and users aware of them. * Improve bundle deployment status error reporting This prints the actual modified status and conditions of a bundle deployment when one of them differs from the expectation, which helps troubleshoot mismatches.
weyfonk
added a commit
to weyfonk/fleet
that referenced
this pull request
Sep 13, 2024
…#2792) * Propagate drift correction error to bundle deployment status When drift correction fails, the Fleet agent now populates the error in the bundle deployment's status, which will help make those errors visible and users aware of them. * Improve bundle deployment status error reporting This prints the actual modified status and conditions of a bundle deployment when one of them differs from the expectation, which helps troubleshoot mismatches.
weyfonk
added a commit
to weyfonk/fleet
that referenced
this pull request
Sep 13, 2024
…#2792) * Propagate drift correction error to bundle deployment status When drift correction fails, the Fleet agent now populates the error in the bundle deployment's status, which will help make those errors visible and users aware of them. * Improve bundle deployment status error reporting This prints the actual modified status and conditions of a bundle deployment when one of them differs from the expectation, which helps troubleshoot mismatches.
thardeck
pushed a commit
that referenced
this pull request
Sep 16, 2024
…2835) * Propagate drift correction error to bundle deployment status When drift correction fails, the Fleet agent now populates the error in the bundle deployment's status, which will help make those errors visible and users aware of them. * Improve bundle deployment status error reporting This prints the actual modified status and conditions of a bundle deployment when one of them differs from the expectation, which helps troubleshoot mismatches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives more visibility to errors which may happen when correcting drift.
A known example causing such errors is updating a port on a service (see kubernetes/kubernetes#105610).
Refers to #2609.
Comes with new integration tests, paving the way for migrating at least some of our end-to-end drift test suite to integration tests (#2771).