[v0.10] Propagate drift correction force mode to Helm rollback #2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weyfonk
changed the title
weyfonk
force-pushed
the
backport-0.10-drift-correction-force-rollback
branch
from
e08effe to
e13293b
Compare
* Propagate drift correction force mode to Helm This enables drift correction to be forced after the fact, which can help users deal with edge cases such as patching ports on services, a case known not to be supported [1] by Helm. [1]: helm/helm#12974 * Remove service status drift end-to-end test case That test case is now covered in integration tests. * Order service drift integration tests This may reduce the risk of flakiness.
weyfonk
force-pushed
the
backport-0.10-drift-correction-force-rollback
branch
from
e13293b to
ba5ffb0
Compare
thardeck
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #2834.
Backport of #2798 to v0.10.
Depends on #2835.
Depends on #2838 for sharding end-to-end tests to pass, following #2830.