Adds predicate when webhook commit changes #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new predicate when the webhook commit is changed in the `GitRepo`. It also filters out `Job` events for creation/deletion, because they add extra reconcile loops that only increase the possibility of race conditions and that are not required. The reconciler already knows when a `Job` is created/deleted because it is the owner and does not need to react upon those 2 events from the cluster. Refers to: rancher#2969 Signed-off-by: Xavi Garcia <[email protected]>
weyfonk
reviewed
Oct 24, 2024
| It("creates a new Job", func() { | ||
| Eventually(func() error { | ||
| jobName := names.SafeConcatName(gitRepoName, names.Hex(repo+webhookCommit, 5)) | ||
| return k8sClient.Get(ctx, types.NamespacedName{Name: jobName, Namespace: gitRepoNamespace}, &job) |
There was a problem hiding this comment.
If more than one job were created, how would we detect it?
There was a problem hiding this comment.
The job name depends on the repopath+commit, so unless the commit changes...we'll have the same job all the time.
We can see from time to time Already Exist errors when trying to re-create the job under race condition circumstances, so only 1 job is possible.
Extra note: the Already exists errors don't mean the reconciler is not working.
If, for whatever reason, 2 reconcile calls are called very close from each other and they get to the code where it checks if the job exists and both get that it doesn't.... both will try to create the job and the fastest one will win, the other one will get the error and exit the reconcile call
Co-authored-by: Corentin Néau <[email protected]>
Co-authored-by: Corentin Néau <[email protected]>
manno
reviewed
Oct 24, 2024
Co-authored-by: Mario Manno <[email protected]>
0xavi0
force-pushed
the
2969-webhook-commit-predicate
branch
from
8a551ca to
994cebb
Compare
manno
approved these changes
Oct 24, 2024
0xavi0
added a commit
to 0xavi0/fleet
that referenced
this pull request
Oct 24, 2024
* Adds predicate when webhook commit changes This adds a new predicate when the webhook commit is changed in the `GitRepo`. It also filters out `Job` events for creation/deletion, because they add extra reconcile loops that only increase the possibility of race conditions and that are not required. The reconciler already knows when a `Job` is created/deleted because it is the owner and does not need to react upon those 2 events from the cluster. Refers to: rancher#2969 --------- Signed-off-by: Xavi Garcia <[email protected]> Co-authored-by: Corentin Néau <[email protected]> Co-authored-by: Mario Manno <[email protected]>
0xavi0
added a commit
that referenced
this pull request
Oct 25, 2024
* Adds predicate when webhook commit changes This adds a new predicate when the webhook commit is changed in the `GitRepo`. It also filters out `Job` events for creation/deletion, because they add extra reconcile loops that only increase the possibility of race conditions and that are not required. The reconciler already knows when a `Job` is created/deleted because it is the owner and does not need to react upon those 2 events from the cluster. Refers to: #2969 --------- Signed-off-by: Xavi Garcia <[email protected]> Co-authored-by: Corentin Néau <[email protected]> Co-authored-by: Mario Manno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new predicate when the webhook commit is changed in the
GitRepo. It also filters outJobevents for creation/deletion, because they add extra reconcile loops that only increase the possibility of race conditions and that are not required.The reconciler already knows when a
Jobis created/deleted because it is the owner and does not need to react upon those 2 events from the cluster.Reconcile calls before filtering the
Jobcreate/delete events:Reconcile calls after filtering the
Jobcreate/delete events: (same gitrepo)Refers to: #2969