[v0.10] Backport of Adds predicate when webhook commit changes #3006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds predicate when webhook commit changes This adds a new predicate when the webhook commit is changed in the `GitRepo`. It also filters out `Job` events for creation/deletion, because they add extra reconcile loops that only increase the possibility of race conditions and that are not required. The reconciler already knows when a `Job` is created/deleted because it is the owner and does not need to react upon those 2 events from the cluster. Refers to: rancher#2969 --------- Signed-off-by: Xavi Garcia <[email protected]> Co-authored-by: Corentin Néau <[email protected]> Co-authored-by: Mario Manno <[email protected]>
0xavi0
changed the title
manno
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new predicate when the webhook commit is changed in the
GitRepo. It also filters outJobevents for creation/deletion, because they add extra reconcile loops that only increase the possibility of race conditions and that are not required.The reconciler already knows when a
Jobis created/deleted because it is the owner and does not need to react upon those 2 events from the cluster.Refers to: #2969
Refers to: #3003