Deduplicate status messages #3042
Merged
+107
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents fleet from crashing due to resources exceeding etcd's configured size limit. Deduplicate messages should only be necessary for edge cases which are not officially supported by fleet but result in ever increasing message sizes. This is due to the messages being copied from one resource to another and back again. Every resource adds its status to the message. This only happens if a cluster group is deployed by a GitRepo, which results in a bundle containing a cluster group. This bundle can only become ready if the cluster group is ready, but if the cluster group points to the cluster of the bundle that deployed the cluster group, this cannot ever happen. The user is expected to fix this situation but deduplicating the messages prevents the message from growing up to the point where etcd's limit is reached and fleet crashes. Deduplicating the messages also has the effect of not changing the status of resources frequently, which results in less controllers being triggered.
weyfonk
reviewed
Nov 6, 2024
weyfonk
approved these changes
Nov 6, 2024
p-se
added a commit
to p-se/fleet
that referenced
this pull request
Dec 3, 2024
(cherry picked from commit a8cafe4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents fleet from crashing due to resources exceeding etcd's
configured size limit.
Deduplicate messages should only be necessary for edge cases which are
not officially supported by fleet but result in ever increasing message
sizes.
This is due to the messages being copied from one resource to another
and back again. Every resource adds its status to the message. This only
happens if a cluster group is deployed by a GitRepo, which results in a
bundle containing a cluster group. This bundle can only become ready if
the cluster group is ready, but if the cluster group points to the
cluster of the bundle that deployed the cluster group, this cannot ever
happen. The user is expected to fix this situation but deduplicating the
messages prevents the message from growing up to the point where etcd's
limit is reached and fleet crashes.
Deduplicating the messages also has the effect of not changing the
status of resources frequently, which results in less controllers being
triggered.
Refers to #2859.