Fix base Fleet chart version resolution for test release #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When releasing test Fleet charts, the test release workflow looks for the latest existing Fleet release, to use it as a base before making a few edits. The previous logic used to find the latest available chart was buggy, in that it would list releases in alphabetical order, which could differ from semver. For instance, chart version `103.1.10+up0.9.11` would be listed between versions `103.1.0+up0.9.0` and `103.1.2+up0.9.2`. Instead, this commit simplifies resolution by first looking at the `package.yaml` file, extracting the chart version from there and looking for the corresponding Fleet version in the charts repository. Resolution would then fail if no corresponding version is found in the repository, but that is far less likely to happen than with the previous logic and would typically be a symptom of a broken state of the charts repository.
weyfonk
force-pushed
the
test-chart-fix-version-resolution
branch
from
ecea16a to
a23bd57
Compare
thardeck
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When releasing test Fleet charts, the test release workflow looks for the latest existing Fleet release, to use it as a base before making a few edits.
The previous logic used to find the latest available chart was buggy, in that it would list releases in alphabetical order, which could differ from semver. For instance, chart version
103.1.10+up0.9.11would be listed between versions103.1.0+up0.9.0and103.1.2+up0.9.2.Instead, this commit simplifies resolution by first looking at the
package.yamlfile, extracting the chart version from there and looking for the corresponding Fleet version in the charts repository. Resolution would then fail if no corresponding version is found in the repository, but that is far less likely to happen than with the previous logic and would typically be a symptom of a broken state of the charts repository.Tested with this job (previous failure example here).
Refers to #1640